Add support for inches as unit of rainfall measure #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for making this addition! Hopefully it will be merged soon. As an American, I can confirm we don't understand mm! Unfortunately, my coding skills aren't good enough to confirm if everything is right. Sorry I can't be more than a cheerleader on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses half of issue 171 by adding inches as a unit of measure for rainfall. This is very important for American users. We have no clue what a mm is! :)
Please note that I don't know how to compile Android apps, so this is not compiled or tested. But the code is so simple that I'm 99% confident that it will work on your first build.