feat: support for SCT error recovery in latest ACS #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ru Wang <[email protected]>
[ FDOPENSRCE-289 ] Signed-off-by: Ru Wang <[email protected]>
|
@DebabrataSTX Could you please help check this PR? |
|
I will take a look at this sometime this week |
|
@wangru-stx, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes for FDOPENSRCE-289.
--sctReadTimerandsctWriteTimerwill be changed from volatile to non-volatile. Because we always default--volatileto false. The only solution is to use a different flag, for example keep--sctReadTimerfor volatile but add--nonVolatileSctReadTimerfor non-volatile. But that adds extra complexity.