bug: Fixing bug pulling telemetry log

Fixing a bug pulling the telemetry log as well as a few other minor clearnup items. Signed-off-by: Tyler Erickson <[email protected]>
Seagate · Jul 26, 2023 · eb2f1c7 · eb2f1c7
1 parent b0f407b
commit eb2f1c7
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/utils/C/openSeaChest/openSeaChest_NVMe.c b/utils/C/openSeaChest/openSeaChest_NVMe.c
@@ -1329,6 +1329,7 @@ int32_t main(int argc, char *argv[])
                     cmdOpts.addr = logBuffer;
                     cmdOpts.dataLen = size;
                     cmdOpts.lid = GET_TELEMETRY_IDENTIFIER;
+                    cmdOpts.lsp = 0x01; // FDCHEST-282 Fix
                     cmdOpts.offset = offset;
 
                     rtnVal = nvme_Get_Log_Page(&deviceList[deviceIter], &cmdOpts);
@@ -1373,6 +1374,7 @@ int32_t main(int argc, char *argv[])
                                 cmdOpts.addr = logBuffer;
                                 cmdOpts.dataLen = size;
                                 cmdOpts.lid = GET_TELEMETRY_IDENTIFIER;
+                                cmdOpts.lsp = 0x01; // FDCHEST-282 Fix
                                 cmdOpts.offset = offset;
 
                                 rtnVal = nvme_Get_Log_Page(&deviceList[deviceIter], &cmdOpts);
@@ -1484,11 +1486,18 @@ int32_t main(int argc, char *argv[])
             {
             case SUCCESS:
                 //nothing to print here since if it was successful, the log will be printed to the screen
+                break;
+			case NOT_SUPPORTED:
+				if (VERBOSITY_QUIET < toolVerbosity)
+                {
+                    printf("Printing Temperature Statistics data is not supported on this drive type.\n");
+                }
+                exitCode = UTIL_EXIT_OPERATION_NOT_SUPPORTED;
                 break;
             default:
                 if (VERBOSITY_QUIET < toolVerbosity)
                 {
-                    printf("A failure occured while trying to get Error Information Log\n");
+                    printf("A failure occured while trying to get Temp Statistics Information Log\n");
                 }
                 exitCode = UTIL_EXIT_OPERATION_FAILURE;
                 break;
@@ -1501,11 +1510,18 @@ int32_t main(int argc, char *argv[])
             {
             case SUCCESS:
                 //nothing to print here since if it was successful, the log will be printed to the screen
+                break;
+			case NOT_SUPPORTED:
+				if (VERBOSITY_QUIET < toolVerbosity)
+                {
+                    printf("Printing PCI Statistics data is not supported on this drive type.\n");
+                }
+                exitCode = UTIL_EXIT_OPERATION_NOT_SUPPORTED;
                 break;
             default:
                 if (VERBOSITY_QUIET < toolVerbosity)
                 {
-                    printf("A failure occured while trying to get Error Information Log\n");
+                    printf("A failure occured while trying to get PCI Statistics Information Log\n");
                 }
                 exitCode = UTIL_EXIT_OPERATION_FAILURE;
                 break;