feat: Adding clang-tidy static analyzer and fixing related issues

added the clang-tidy static analyzer option and worked on resolving all detected issues as best I could. Also switched to some new safe_ functions implemented in opensea-common where necessary to add bounds checking. Signed-off-by: Tyler Erickson <[email protected]>
Seagate · Nov 11, 2024 · bd4f05b · bd4f05b
1 parent 2805734
commit bd4f05b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,9 +1,11 @@
-Checks: '-*,modernize-*,cert-*,bugprone-*,-bugprone-easily-swappable-parameters'
+Checks: '-*,modernize-*,cert-*,bugprone-*,-bugprone-easily-swappable-parameters,clang-analyzer-*,-clang-analyzer-deadcode.DeadStores'
 #other available checks: clang-analyzer-*, performance-*, readability-*, misc-*
 #Disabled checks:
 # -bugprone-easily-swappable-parameters - warns a LOT. Sometimes on functions meant to look like standardized C11 annex k functions
 #                                         While a overall useful thing to consider, it's too noisy right now and it may make the API
 #                                         harder to use to resolve all of these.
+# -clang-analyzer-deadcode.DeadStores   - A lot of warnings related to this. Will be good to cleanup, but due to how many
+#                                         there currently are, it's better to concentrate on other more pressing problems
 WarningsAsErrors: ''
 HeaderFilterRegex: '.*'
 AnalyzeTemporaryDtors: false

diff --git a/subprojects/opensea-common b/subprojects/opensea-common
diff --git a/subprojects/opensea-operations b/subprojects/opensea-operations
diff --git a/subprojects/opensea-transport b/subprojects/opensea-transport