Skip to content

Commit

Permalink
clean: Cleaning up old TODO comments
Browse files Browse the repository at this point in the history
Cleaning up old TODO comments that were resolved long ago, not really a TODO and converted to a comment.

Signed-off-by: Tyler Erickson <[email protected]>
  • Loading branch information
vonericsen committed Jun 11, 2024
1 parent 03b564c commit 1ba62ec
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions include/openseachest_util_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ extern "C"
UTIL_EXIT_FILE_ALREADY_EXISTS,
UTIL_EXIT_NEED_ELEVATED_PRIVILEGES,
UTIL_EXIT_NOT_ENOUGH_RESOURCES,
//TODO: More generic exit codes go here
//More generic exit codes go here
UTIL_EXIT_ERROR_WRITING_FILE, //added 5/19/20
//Tool specific exit codes go here
UTIL_TOOL_SPECIFIC_STARTING_ERROR_CODE = 32,//Use this value in a tool to start the tool's specific error code enumeration
Expand Down Expand Up @@ -1821,7 +1821,7 @@ extern "C"
bool forceUppercase;
bool forceLowercase;
bool invertCase;
//TODO: add other modifications as we find or hear other that work with some odd BIOS chips.
//add other modifications as we find or hear other that work with some odd BIOS chips.
}ataSecPWModifications;
#define ATA_SECURITY_PASSWORD_MODIFICATIONS passwordModificationType
#define ATA_SECURITY_PASSWORD_MODIFICATIONS_VAR ataSecPWModifications ATA_SECURITY_PASSWORD_MODIFICATIONS = { false, false, false, false, false, false, false, false, false, false };
Expand All @@ -1840,7 +1840,7 @@ extern "C"
#define ATA_SECURITY_USING_MASTER_PW_LONG_OPT_STRING "ataSecPassType"
#define ATA_SECURITY_USING_MASTER_PW_LONG_OPT { ATA_SECURITY_USING_MASTER_PW_LONG_OPT_STRING, required_argument, NULL, 0 }

//TODO: This needs to handle the request to do secure erase AND which TYPE of secure erase
//This needs to handle the request to do secure erase AND which TYPE of secure erase
#define ATA_SECURITY_ERASE_OP performATASecurityErase
#define ATA_SECURITY_ERASE_OP_VARS \
bool ATA_SECURITY_ERASE_OP = false; \
Expand Down Expand Up @@ -1925,7 +1925,7 @@ extern "C"
#define SCSI_MP_SAVE_LONG_OPT_STRING "scsiMPSave"
#define SCSI_MP_SAVE_LONG_OPT { SCSI_MP_SAVE_LONG_OPT_STRING, required_argument, NULL, 0 }

//show scsi mode page (TODO: different output modes) output modes: classic vs "neat" or some other name...
//show scsi mode page output modes: classic vs "neat" or some other name...
#define SCSI_SHOW_MP_OP showSCSIModePage
#define SCSI_SHOW_MP_PAGE_NUMBER showModePageNumber
#define SCSI_SHOW_MP_SUBPAGE_NUMBER showModeSubPageNumber
Expand Down
2 changes: 1 addition & 1 deletion src/EULA.c
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ void print_Open_Source_Licenses(void)
#endif
#endif
#elif defined (__sun) || defined (_AIX)
//TODO: Any special license for system libc/etc that needs to be shown. Cannot easily identify one at this time - TJE
//Any special license for system libc/etc that needs to be shown. Cannot easily identify one at this time - TJE
#else
#error Please update #if for system library licenses!
#endif
Expand Down
6 changes: 3 additions & 3 deletions src/openseachest_util_options.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ void print_Elevated_Privileges_Text(void)
#if defined (_WIN32)
printf("In Windows, open the Command Prompt using \"Run as administrator\".\n");
#elif defined (__unix__) || defined(__APPLE__)
//TODO: handle the various linux/unix/unix-like OSs with more ifdefs here
//handle the various linux/unix/unix-like OSs with more ifdefs here
#if defined (__linux__)
#if defined (VMK_CROSS_COMP)
printf("In ESXi, put sudo before the command. This may require inputting your login password.\n");
Expand All @@ -118,7 +118,7 @@ void print_Elevated_Privileges_Text(void)
#elif defined (__sun)
printf("In Solaris, put sudo before the command. This may require inputting your login password.\n");
printf("In Solaris, log in to a root terminal (su), then execute the command. This requires the root password.\n");
#else //generic unix/unix-like case //TODO: Add more OS specific ifdefs to customize messages above
#else //generic unix/unix-like case //Add more OS specific ifdefs to customize messages above
printf("In Linux/Unix, put sudo before the command. This may require inputting your login password.\n");
printf("In Linux/Unix, log in to a root terminal (su), then execute the command. This requires the root password.\n");
#endif
Expand Down Expand Up @@ -245,7 +245,7 @@ void print_SeaChest_Util_Exit_Codes(int numberOfToolSpecificExitCodes, ptrToolSp
printf("\t%d = Cannot Open File\n", UTIL_EXIT_CANNOT_OPEN_FILE);
printf("\t%d = File Already Exists\n", UTIL_EXIT_FILE_ALREADY_EXISTS);
printf("\t%d = Need Elevated Privileges\n", UTIL_EXIT_NEED_ELEVATED_PRIVILEGES);
//TODO: more generic exit code help above this comment. Tool specific exit codes in if statement below
//more generic exit code help above this comment. Tool specific exit codes in if statement below
if (numberOfToolSpecificExitCodes > 0 && toolSpecificExitCodeList)
{
printf("\t---%s specific exit codes---\n", toolName);
Expand Down

0 comments on commit 1ba62ec

Please sign in to comment.