Dynamic title from pisa #731
Open
+91
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcsaszar
approved these changes
Jan 31, 2025
Comment on lines
+3
to
+5
| /** | ||
| * Fetches the schema for `subPath`. | ||
| * */ |
There was a problem hiding this comment.
- FYI This comment and the duplicate in
fetchAttributesexplain internals which are not really interesting for the caller.
Comment on lines
+26
to
+29
| title: async () => | ||
| (await load(currentLanguage)) === 'de' | ||
| ? 'Allgemeine Marketingzustimmung' | ||
| : 'General marketing consent', |
There was a problem hiding this comment.
- FMI Where can I find this in use in the content?
| @@ -16,6 +16,8 @@ async function attributes(): Promise<DataAttributeDefinitions> { | |||
| export function opportunityParamsFallback() { | |||
| return { | |||
| attributes, | |||
| title: async () => | |||
| (await load(currentLanguage)) === 'de' ? 'Chance' : 'Opportunity', | |||
There was a problem hiding this comment.
- FYI The docs use
Geschäftschance. https://help.pisasales.com/de/lead-management-portal-cf5ef30b4513d38a
| @@ -169,6 +169,8 @@ async function attributes(): Promise<DataAttributeDefinitions> { | |||
| export function ticketParamsFallback() { | |||
| return { | |||
| attributes, | |||
| title: async () => | |||
| (await load(currentLanguage)) === 'de' ? 'Ticket' : 'Ticket', | |||
| @@ -29,6 +29,10 @@ async function attributes(): Promise<DataAttributeDefinitions> { | |||
| export function serviceObjectDocumentParamsFallback() { | |||
| return { | |||
| attributes, | |||
| title: async () => | |||
| (await load(currentLanguage)) === 'de' | |||
| ? 'Serviceobjektdokument' | |||
There was a problem hiding this comment.
- FYI maybe make the composition clearer by Serviceobjekt-Dokument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pisa still needs to provide
title. But the fallback is good enough for now.