fix to Next issue of char escaping #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scottylol ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
For some reason doesn't work on netlify deploy preview (except for noob fallback mode) despite working on localhost |
Andrew923
changed the title
|
Testing by directly typing url in localhost and netlify doesn't work (http://localhost:3000/search?q=g c++) because characters aren't escaped when you directly type them in, but setting the search engine to http://localhost:3000/search?q= and typing in the search bar works because then the characters are escaped. |
hdavidethan
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Encodes query (both noob and normal) and default redirect (noob)
Closes #48, #54, #62
Type of change
[x ] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Tested on localhost for both normal and noob mode
g C++,C++,h&m