Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Oxford Dictionary shortcut #50

Closed
wants to merge 2 commits into from
Closed

Added Oxford Dictionary shortcut #50

wants to merge 2 commits into from

Conversation

sanjana-shriram
Copy link

@sanjana-shriram sanjana-shriram commented Oct 1, 2022

Description

Added a new command, define, to the list of commands. Define redirects the user to the Oxford English Dictionary and search terms can be included in the query.

Closes #43

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This new command was tested locally in the browser.

  • Navigate to localhost:3000 and check if define shows up on the list of commands
  • Type "define x" where x is the word you want to define in the browser

Test Configuration:

  • Node.js version: 16.17.0
  • Python version: 3.9
  • Desktop/Mobile: Desktop
  • OS: Windows
  • Browser: Chrome

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@netlify
Copy link

netlify bot commented Nov 19, 2022

Deploy Preview for scottylol ready!

Name Link
🔨 Latest commit 0c068be
🔍 Latest deploy log https://app.netlify.com/sites/scottylol/deploys/63793380b6c6020008c420a8
😎 Deploy Preview https://deploy-preview-50--scottylol.netlify.app/help
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rajgodse rajgodse self-requested a review November 19, 2022 19:50
Copy link
Collaborator

@rajgodse rajgodse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanjana-shriram sanjana-shriram closed this by deleting the head repository Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bootcamp] [Feature] Add dictionary search
2 participants