Added delete develop-apps task that runs every day a 4 am. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churnikov
reviewed
Nov 15, 2023
apps/tasks.py
Outdated
Comment on lines
641
to
644
| @app.task | ||
| def delete_old_objects(): | ||
| # Define the time threshold (24 hours ago) | ||
| threshold_time = timezone.now() - timezone.timedelta(days=7) |
There was a problem hiding this comment.
Seems like a couple of lines of docstrings would be nice
I would also like to suggest making this configurable via settings.py .
There was a problem hiding this comment.
Great suggestion. Ill add docstring.
Regarding the settings, i agree but maybe a different PR since this must update the information regarding this plus the charts repo. Agree?
There was a problem hiding this comment.
Docstring added
…om:ScilifelabDataCentre/stackn into feature/remove-develop-apps-after-one-week
churnikov
requested changes
Nov 16, 2023
apps/tasks.py
Outdated
|
|
||
| @app.task | ||
| def delete_old_objects(): | ||
| ''' |
There was a problem hiding this comment.
Use "
Black would have fixed it, so don't forget pre-commit hooks :))
There was a problem hiding this comment.
Thanks! I've fixed it now!
churnikov
approved these changes
Nov 16, 2023
sandstromviktor
deleted the
feature/remove-develop-apps-after-one-week
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a scheduled job (run by the celery worker) that checks if any app of type "Develop" (i.e., jupyterlab, vscode or rstudio) is older than 7 days. If it is older, it will delete the app (both on the cluster and the database).
The job is run once a day at 4 am.
You can test this by changing the job to interval (set to 6 seconds) and change the threshold in tasks.py to 1 minute. Then deploy a jupyterlab and see that it gets removed after 1 minute.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!