Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS 654 serve apps should have copy api endpoint button #94

Conversation

sandstromviktor
Copy link
Contributor

Description

I've changed the Open button for apps to be Copy api endpoints when the app is torch-serve, tensorflow-serve or python.
It applies to the public apps page and the project view page.

I also added a small badge to the status in project overview so the users can see which apps are public or not.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have updated the release notes (releasenotes.md)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@sandstromviktor sandstromviktor added enhancement Improvement of existing feature or request new feature A new feature labels Nov 3, 2023
@sandstromviktor sandstromviktor requested a review from a team November 3, 2023 15:45
@sandstromviktor sandstromviktor self-assigned this Nov 3, 2023
Copy link
Collaborator

@akochari akochari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sandstromviktor sandstromviktor merged commit 161f725 into develop Nov 7, 2023
2 checks passed
@sandstromviktor sandstromviktor deleted the SS-654-serve-apps-should-have-copy-api-endpoint-button branch November 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or request new feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants