SS-1229 Fix of the bug not saving deleted on date #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue SS-1229. We didn't save the deleted_on date when an app was deleted by the users. In addition, I added timezone info to the saved value. I also added a unit test to check that this field was populated on deletion.
This PR also fixes the issue SS-1238. Persistent volumes that were deleted were shown as options when launching a file manager or notebooks.
Finally, unrelated change - fixed the links to documentation from the app creation/edit form because we missed that in past PRs.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.