Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-1229 Fix of the bug not saving deleted on date #264

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

akochari
Copy link
Collaborator

@akochari akochari commented Dec 2, 2024

Description

This PR fixes the issue SS-1229. We didn't save the deleted_on date when an app was deleted by the users. In addition, I added timezone info to the saved value. I also added a unit test to check that this field was populated on deletion.
This PR also fixes the issue SS-1238. Persistent volumes that were deleted were shown as options when launching a file manager or notebooks.
Finally, unrelated change - fixed the links to documentation from the app creation/edit form because we missed that in past PRs.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@akochari akochari added the bug Something isn't working label Dec 2, 2024
@akochari akochari marked this pull request as ready for review December 3, 2024 08:36
@akochari akochari changed the title SS-1229 Fix of the bug not setting deleted on SS-1229 Fix of the bug not saving deleted on Dec 3, 2024
studio/settings.py Show resolved Hide resolved
Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work.

@akochari akochari changed the title SS-1229 Fix of the bug not saving deleted on SS-1229 Fix of the bug not saving deleted on date Dec 5, 2024
@akochari akochari merged commit 13c1dfe into develop Dec 5, 2024
2 checks passed
@akochari akochari deleted the deleted-on-bug-etc branch December 5, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants