Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS 1233 Kubernetes manifest yaml validation #255

Merged
merged 20 commits into from
Dec 10, 2024

Conversation

alfredeen
Copy link
Member

@alfredeen alfredeen commented Nov 22, 2024

Description

This PR adds k8s manifest validation when creating or re-deploying new k8s deployments. The validation is run in development environments (DEBUG mode). The validation uses kubernetes-validate to validate the deployment yaml and also performs a light validation of the custom kubernetes-pod-patches section if it exists in a ConfigMap.

If the manifest is determined to be invalid, then the values and deployment yaml files are saved to the charts/values directory for further investigation. In that case 2 files are saved:

A values file: [date]_[uuid].yaml
A deployment file: [date]_[uuid]_deployment.yaml

Jira link

Checklist

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@alfredeen alfredeen self-assigned this Nov 22, 2024
apps/tasks.py Outdated Show resolved Hide resolved
apps/tasks.py Outdated Show resolved Hide resolved
apps/tasks.py Outdated Show resolved Hide resolved
apps/tasks.py Show resolved Hide resolved
@alfredeen alfredeen changed the title SS 1073 Shiny-proxy volume support SS 1233 Kubernetes manifest yaml validation Dec 3, 2024
@alfredeen alfredeen requested a review from a team December 3, 2024 13:30
@alfredeen alfredeen marked this pull request as ready for review December 3, 2024 13:30
apps/tasks.py Show resolved Hide resolved
apps/tasks.py Outdated Show resolved Hide resolved
apps/tasks.py Show resolved Hide resolved
apps/tests/test_kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Show resolved Hide resolved
apps/tests/test_kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/tasks.py Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
apps/types_/kubernetes_deployment_manifest.py Outdated Show resolved Hide resolved
@alfredeen alfredeen requested a review from churnikov December 9, 2024 19:39
@alfredeen alfredeen merged commit 43c8fd7 into develop Dec 10, 2024
2 checks passed
@alfredeen alfredeen deleted the ss-1073-shinyproxy-volume-support branch December 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants