-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS 1233 Kubernetes manifest yaml validation #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churnikov
reviewed
Nov 26, 2024
…g together with tasks.
alfredeen
changed the title
SS 1073 Shiny-proxy volume support
SS 1233 Kubernetes manifest yaml validation
Dec 3, 2024
churnikov
reviewed
Dec 5, 2024
churnikov
reviewed
Dec 9, 2024
churnikov
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds k8s manifest validation when creating or re-deploying new k8s deployments. The validation is run in development environments (DEBUG mode). The validation uses kubernetes-validate to validate the deployment yaml and also performs a light validation of the custom kubernetes-pod-patches section if it exists in a ConfigMap.
If the manifest is determined to be invalid, then the values and deployment yaml files are saved to the charts/values directory for further investigation. In that case 2 files are saved:
A values file: [date]_[uuid].yaml
A deployment file: [date]_[uuid]_deployment.yaml
Jira link
Checklist