Bugfix - Settings not working for non-admin #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churnikov
reviewed
Nov 17, 2023
sandstromviktor
changed the title
…m:ScilifelabDataCentre/stackn into bugfix/settings-not-working-for-non-admin
sandstromviktor
deleted the
bugfix/settings-not-working-for-non-admin
branch
| if new_release_name and current_release_name != new_release_name: | ||
| # This handles the case where a user creates a new subdomain, we must update the helm release aswell | ||
| new_url = appinstance.table_field["url"].replace(current_release_name, new_release_name) | ||
| appinstance.table_field.update({"url": new_url}) |
There was a problem hiding this comment.
I don't think this gets saved in the database. Might need to use save to make sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found a small bug. When deploying a Develop app as a non-superuser, the option to change subdomain is disabled.
This causes the view logic in
apps/views.pyto try to replace a string withNone, and it crashes.How to spot the bug:
This PR proposes a quick workaround for this.
I've also:
RESET_DBenv variable in the wrong container indocker-compose.yamlTypes of changes
What types of changes does your code introduce to Serve?
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.