Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docs work with strict mode #383

Merged
merged 6 commits into from
Jul 25, 2022

Conversation

vikram-s-narayan
Copy link
Contributor

Fixes #363

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #383 (b58c9a7) into master (b8e31a6) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   79.57%   79.65%   +0.08%     
==========================================
  Files          16       16              
  Lines        2335     2335              
==========================================
+ Hits         1858     1860       +2     
+ Misses        477      475       -2     
Impacted Files Coverage Δ
src/GEKPLS.jl 95.04% <0.00%> (+0.82%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@vikram-s-narayan
Copy link
Contributor Author

vikram-s-narayan commented Jul 23, 2022

I'm not able to reproduce the Documentation / build error - ERROR: LoadError: TypeError: non-boolean (Vector{Symbol}) used in boolean context on my local system. So this appears to be something that's happening on GitHub only?

@ChrisRackauckas
Copy link
Member

Just an old version of documenter.

@ChrisRackauckas
Copy link
Member

Packages need to be added to the docs/Project.toml

@ChrisRackauckas ChrisRackauckas merged commit 57a3b89 into SciML:master Jul 25, 2022
@vikram-s-narayan vikram-s-narayan deleted the fix_docs branch July 25, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting "strict mode" in docs build throws error
2 participants