Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow remade initialization systems to be incomplete #3301

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feat: allow remade initialization systems to be incomplete #3301

merged 4 commits into from
Jan 16, 2025

Conversation

AayushSabharwal
Copy link
Member

Close #3295

@AayushSabharwal
Copy link
Member Author

This also sets the stage for enabling the has_tearing_state(sys) && get_tearing_state(sys) !== nothing requirement for building initialization problems.

@ChrisRackauckas
Copy link
Member

looks like there's some test failures?

@AayushSabharwal
Copy link
Member Author

Yeah. Those tests work locally bar the Extension ones, but that's a missing overload in HomotopyContinuation.jl.

@ChrisRackauckas ChrisRackauckas merged commit 2ca9ecf into SciML:master Jan 16, 2025
33 of 42 checks passed
@AayushSabharwal AayushSabharwal deleted the as/incomplete-init branch January 16, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AayushSabharwal @ChrisRackauckas