Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate balanced precision #333

Merged
merged 34 commits into from
Apr 13, 2023
Merged

Calculate balanced precision #333

merged 34 commits into from
Apr 13, 2023

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Mar 29, 2023

Issues

Change(s) made

  • New function calc_balanced_precision() implements Equation 1 & 7 from Wu et al. 2021 (10.1016/j.ajhg.2021.08.012).
  • Examples show how to calculate and plot balanced precision and AUBPRC.

Checklist

(Strikethrough any points that are not applicable.)

  • Write unit tests for any new functionality or bug fixes.
  • Update docs if there are any API changes:
  • Update NEWS.md if this includes any user-facing changes.
  • The check workflow succeeds on your most recent commit. This is always required before the PR can be merged.

@kelly-sovacool kelly-sovacool requested review from a team, sklucas and courtneyarmour and removed request for a team March 29, 2023 19:44
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1c5fa41) 98.26% compared to head (1f7be32) 98.26%.

❗ Current head 1f7be32 differs from pull request most recent head bfa2345. Consider uploading reports for the commit bfa2345 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          13       13           
  Lines        1152     1155    +3     
=======================================
+ Hits         1132     1135    +3     
  Misses         20       20           
Impacted Files Coverage Δ
R/performance.R 100.00% <100.00%> (ø)
R/plot.R 79.16% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review March 29, 2023 23:03
Copy link
Member

@sklucas sklucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding functionality for calculating balanced precision - approved.

@kelly-sovacool kelly-sovacool merged commit 2b3ded6 into main Apr 13, 2023
@kelly-sovacool kelly-sovacool deleted the aubprc branch April 13, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate the area under the balanced precision-recall curve (AUBPRC)
3 participants