Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolves #1462] Diff fails if stack ignore is True #1463

Closed
wants to merge 1 commit into from

Conversation

goopilot
Copy link

@goopilot goopilot commented May 1, 2024

Trying to fix #1462

@alex-harvey-z3q
Copy link
Contributor

@goopilot You mention here that this PR needs more work
#1462 (comment)

Is that still the case and are you planning to revise this or should we close this PR? Thanks!

Copy link
Contributor

@alex-harvey-z3q alex-harvey-z3q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments above.

@goopilot
Copy link
Author

@goopilot You mention here that this PR needs more work #1462 (comment)

Is that still the case and are you planning to revise this or should we close this PR? Thanks!

@alexharv074 as stated by @zaro0508 diff does not support ignore, so as I understood more work need to be done to add ignore support for diff. I think this PR can be cancelled.

@alex-harvey-z3q
Copy link
Contributor

Thank you @goopilot ! Please reopen when you have a solution and feel free to discuss on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff fails if stack Ignore parameter set to True
2 participants