Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added time-based greetings #752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added time-based greetings #752

wants to merge 1 commit into from

Conversation

Sanket2004
Copy link
Contributor

🛠️ Fixes Issue

👨‍💻 Changes proposed

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Screenshot_20221027_165441
Time-based greeting added.

@netlify
Copy link

netlify bot commented Oct 27, 2022 •
edited
Loading

✅ Deploy Preview for codeincommunity ready!

Name Link
🔨 Latest commit 5fa7eeb
🔍 Latest deploy log https://app.netlify.com/sites/codeincommunity/deploys/635a6b02072b260008b5d7f1
😎 Deploy Preview https://deploy-preview-752--codeincommunity.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Naresh-chandanbatve
Naresh-chandanbatve reviewed Oct 29, 2022
View reviewed changes
Copy link
Contributor

@Naresh-chandanbatve Naresh-chandanbatve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove demo text
it looks bad when the page is loading
keep it blank until the greeting loads.

@Sanket2004
Copy link
Contributor Author

You should remove demo text it looks bad when the page is loading keep it blank until the greeting loads.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naresh-chandanbatve Naresh-chandanbatve Naresh-chandanbatve approved these changes

@SauravMukherjee44 SauravMukherjee44 SauravMukherjee44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sanket2004 @Naresh-chandanbatve @SauravMukherjee44