Refactoring the 404 page #674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for codeincommunity ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
It's not responsive |
tamalCodes
added
bug
tamalCodes
requested changes
Oct 14, 2022
|
|
Can you please provide the
|
|
@iamtamal I have resolved all the conflicts and provided the issue number in the PR. |
The thing is you have not even made an issue.
|
tamalCodes
requested changes
Oct 28, 2022
| background-image: url(https://cdn.dribbble.com/users/285475/screenshots/2083086/dribbble_1.gif); | ||
| height: 400px; | ||
| background-position: center; | ||
| body{ |
There was a problem hiding this comment.
Donot make changes to body, make changes only to classnames. or id
| border:2px solid rgb(247,184,1); | ||
| } | ||
| @media only screen and (max-width:700px){ | ||
| body{ |
There was a problem hiding this comment.
Donot make changes to body , as this might affect other pages later on !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👨💻 Changes proposed
✔️ Check List (Check all the applicable boxes)
📄 Note to reviewers
📷 Screenshots
closes #656