Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue around host garbage collection #343

Merged
merged 1 commit into from
Jan 15, 2025
+2 −2
Merged

Fix issue around host garbage collection #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions broker/hosts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ def __init__(self, **kwargs):

def __del__(self):
"""Try to close the connection on garbage collection of the host instance."""
self.close()
# object.__del__ DNE, so I don't have to call it here.
if hasattr(self, "_session") and self._session is not None:
self.close()
# If host inherits from a different class with __del__, it should get called through super

@property
Expand Down
Loading