os/drivers/lcd/: Remove logo specific code from bus specific files #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i_lcd.c to logo.c Reduces dependency from mipi_lcd.c by moving logo specific code to logo.c file. There are three functions defined inside logo.c file -: 1)lcd_logo_allocate_buffer(): It allocate buffer for logo data. If software rotation is enabled it utilizes software rotation buffer else a new buffer is created. 2)lcd_logo_fill_buffer(): It fills the logo buffer by identifying correct area. 3)lcd_logo_release_buffer(): It releases the logo buffer memory.
|
Remove logo specific code from bus specific files (mipi_lcd.c). |
namanjain7
changed the title
|
@namanjain7 Sorry, because of urgent issue, review is pending. |
ewoodev
reviewed
Jan 21, 2025
| @@ -247,6 +249,7 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd, unsigned long arg) | |||
| } | |||
| break; | |||
| case LCDDEVIO_PUTAREA: { | |||
| lcd_logo_release_buffer(); | |||
| #if defined(CONFIG_LCD_FLUSH_THREAD) | |||
There was a problem hiding this comment.
If CONFIG_LCD_FLUSH_THREAD is enabled, we don't need buffer for only lcd logo
ewoodev
reviewed
Jan 21, 2025
Comment on lines
+60
to
+68
| #if !defined(CONFIG_LCD_SW_ROTATION) | ||
| if (lcd_init_fullscreen_image != NULL) { | ||
| kmm_free(lcd_init_fullscreen_image); | ||
| } | ||
| #endif | ||
| if (!lcd_init_fullscreen_image) { | ||
| lcd_init_fullscreen_image = NULL; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| #if !defined(CONFIG_LCD_SW_ROTATION) | |
| if (lcd_init_fullscreen_image != NULL) { | |
| kmm_free(lcd_init_fullscreen_image); | |
| } | |
| #endif | |
| if (!lcd_init_fullscreen_image) { | |
| lcd_init_fullscreen_image = NULL; | |
| } | |
| } | |
| if (!lcd_init_fullscreen_image) { | |
| #if !defined(CONFIG_LCD_SW_ROTATION) | |
| kmm_free(lcd_init_fullscreen_image); | |
| #endif | |
| lcd_init_fullscreen_image = NULL; | |
| } | |
| } | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces dependency from mipi_lcd.c by moving logo specific code to logo.c file. There are three functions defined inside logo.c file -: 1)lcd_logo_allocate_buffer(): It allocate buffer for logo data. If software rotation is enabled it utilizes software rotation buffer else a new buffer is created. 2)lcd_logo_fill_buffer(): It fills the logo buffer by identifying correct area. 3)lcd_logo_release_buffer(): It releases the logo buffer memory.