Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: use onecc on ubuntu 24.04 #14514

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Draft: use onecc on ubuntu 24.04 #14514

wants to merge 2 commits into from

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Jan 2, 2025

  • Install command for ubuntu 24.04: same with ubuntu 18.04 to use python 3.8 explicitly

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]

@hseok-oh
Draft: use onecc on ubuntu 24.04
c728272 
- Install command for ubuntu 24.04: same with ubuntu 18.04 to use python 3.8 explicitly

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh
Fix cmake
b9f7686
@hseok-oh
Copy link
Contributor Author

hseok-oh commented Jan 2, 2025

I tested locally (ubuntu 24.04)

$ ./nncc configure -DEXTERNALS_BUILD_THREADS=24 -DCMAKE_BUILD_TYPE=Release
$ ./nncc build -j24
$ ./nncc install --prefix build/out
$ ./build/out/bin/one-prepare-venv
$ ./build/out/test/prepare_test_materials.sh
$ ./build/out/test/runtestall.sh
...
ALL TESTS PASSED!

@hseok-oh
Copy link
Contributor Author

hseok-oh commented Jan 3, 2025

@seanshpark Is this draft looks OK?

This was referenced Jan 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hseok-oh