-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Dropdown component & add automatic "null option" #1517
Open
robines
wants to merge
20
commits into
master
Choose a base branch
from
robin/dropdown-add-null-option
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for prepending a null/blank option automatically
Mathias-a
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snorre98
approved these changes
Oct 8, 2024
Venter på #1510 før jeg merger |
…/Samfundet4 into robin/dropdown-add-null-option
robines
changed the title
Add addNullOption argument to Dropdown
Refactor Dropdown component
Oct 25, 2024
robines
changed the title
Refactor Dropdown component
Refactor Dropdown component & add automatic "null option"
Oct 25, 2024
…/Samfundet4 into robin/dropdown-add-null-option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drastically improve the Dropdown component:
nullOption
for automatically prepending a "null option" to the top of the dropdown optionsnull
as its value.Also updated usage across project