[App Extensibility] default configuration files have valid, working values (@W-17618701@) #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the extensions' default config files no longer have any placeholders for now.
adamraya
approved these changes
Jan 31, 2025
alexvuong
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we wanted developers to be able to generate a project with app extensions installed and then run the project with success (without any further configurations).
Since currently there is a lack of certain features (like validating the configurations), let's make sure that the default config that comes with each extension is valid and working. There should not be any placeholder values.
How to test-drive the PR
node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --outputDir /tmp/foobarcd /tmp/foobarnpm startto run the project.