Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic enablePWAKitPrivateClient that is based on config #1952

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

htuzel
Copy link

@htuzel htuzel commented Aug 2, 2024

Previously, if you were using Template Extensibility feature, it was unnecessary to create whole overrides/app/components/_app-config/index.jsx if you only want to use PWAKitPrivateClient.

Description

Previously, if you were using Template Extensibility feature, it was unnecessary to create whole overrides/app/components/_app-config/index.jsx if you only wanted to use PWAKitPrivateClient.
it is said that Projects generated from PWA Kit 3.5 and above will be configured to use an SLAS private client by default in the documentation, with this PR, if you are using Template Extensibility, you can configure everything via configuration

Types of Changes

  • Other changes (non-breaking changes that does not fit any of the above)

Changes

Added a new parameter on default.js file to manage PWAKitPrivateClient feature and it passed to _app-config file

How to Test-Drive This PR

  • Create a new PWA-Kit project
  • Create a private SLAS client and add/configure it for your SFCC instance
  • Enable enablePWAKitPrivateClient by changing default false value
  • See if it works

Checklists

General

  • Changes are covered by test cases

Accessibility Compliance

You must check off all items in one of the follow two lists:

Localization

  • Don't need localization change

htuzel added 2 commits August 2, 2024 23:56
it is said that Projects generated from PWA Kit 3.5 and above will be configured to use a SLAS private client by default in the documentation, but when we use template override feature we need to override `overrides/app/components/_app-config/index.jsx` file unnecessary because `enablePWAKitPrivateClient` prop is hardcoded (uncommented) and it can be managed via config.

Signed-off-by: Hayreddin Tüzel <[email protected]>
Signed-off-by: Hayreddin Tüzel <[email protected]>
@htuzel htuzel requested a review from a team as a code owner August 2, 2024 22:07
@htuzel htuzel changed the title Dynamic enablePWAKitPrivateClient that is based on json Dynamic enablePWAKitPrivateClient that is based on config Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant