Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update width and height options #263

Merged
merged 10 commits into from
Aug 23, 2024
Merged

Conversation

SalOne22
Copy link
Owner

@Mikachu2333 what do you think about this change? I think that 200w is more understandable than 200x_

@SalOne22 SalOne22 linked an issue Aug 20, 2024 that may be closed by this pull request
@Mikachu2333
Copy link
Collaborator

Agree.
By the way, what would happened if user input w200? Panic or treat 200 as height as normal, and what if input 200 w?

We may need to take into account common mistakes made by our users.

@SalOne22
Copy link
Owner Author

SalOne22 commented Aug 20, 2024

what would happened if user input w200? Panic or treat 200 as height as normal, and what if input 200 w?

Will be parsing error. I change logic a bit that if w or h is present in string it will parse normally

@Mikachu2333
Copy link
Collaborator

Will be parsing error. I change logic a bit that if w or h is present in string it will parse normally

200wh this?

if (`w`.exist and `h`.exist){
    error()
}

@Mikachu2333
Copy link
Collaborator

crash when input 0w @SalOne22

Copy link
Collaborator

@Mikachu2333 Mikachu2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything else?

@SalOne22
Copy link
Owner Author

LGTM

@SalOne22 SalOne22 merged commit 103f5cb into main Aug 23, 2024
10 checks passed
@SalOne22 SalOne22 deleted the bugfix/224-add-width-height-options branch August 23, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resize cannot Maintain aspect ratio
2 participants