Fix multi-user service not working with packet #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
decrypted或许在continue之前切一下片重置一下len会更好？不重置len的话或许会重新分配底层数组导致潜在的性能损失 我只看了gcm的实现，不清楚其他的是不是也有类似逻辑 |
|
@Yuzuki616 他这里校验的是cap，不会导致重分配底层数组的 |
|
但是total是根据dst的len计算的吧 |
dst传入的始终是len为0的原slice |
|
ok，是我的理解出了问题，因为我昨天在修复的时候让dst和返回值共用了同一个变量，不好意思，感谢您的修复。 |
|
Any progress? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5