IT-4004: Update notebook product to use Docker named volumes, change RStudio mount point, and update container versions #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RStudio mount point, and update container versions
zaro0508
approved these changes
Nov 14, 2024
| env: | ||
| NETWORK_NAME: | ||
| 'Fn::FindInMap': [GlobalVars, DockerNetworkName, Value] | ||
| NOTEBOOK_CONTAINER_NAME: | ||
| 'Fn::FindInMap': [GlobalVars, NotebookContainerName, Value] | ||
| EC2_WORK_DIR: | ||
| 'Fn::FindInMap': [NotebookTypeToInitParams, !Ref NotebookType, EC2WorkDir] | ||
| WORK_VOLUME_NAME: |
There was a problem hiding this comment.
(Optional) I would suggest normalizing JUPYTER_WORK_DIR and RSTUDIO_WORK_DIR to just NOTEBOOK_WORK_DIR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current R-Studio notebook loses user content placed in /home/rstudio (the home directory).
This PR changes the volume mount point from /home/rstudio/work subfolder to /home/rstudio.
It also changes from mounting a user folder to mounting a Docker "named volume". The reason for this
is so that the initial content of /home/rstudio is preserved (copied from the container to the host volume rather
than being masked by the empty host volume).
We update the versions of the notebook containers: