Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IT-3523] Upload test artifacts for branches beginning with test/ #335

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ConsoleCatzirl
Copy link
Member

@ConsoleCatzirl ConsoleCatzirl commented Jul 17, 2024

Upload test artifacts for branches that start with test/ to the itsandbox account. This automates a manual step needed for testing changes to AMIs used by service catalog products.

Also address or ignore new cfn-lint findings:

  • Address E3009:, mode minimum length is 6 characters
  • Ignore E3012 for PyPlate
  • Address W3687: ['FromPort', 'ToPort'] are ignored when using 'IpProtocol' value '-1'
  • Ignore W6001: The output value is an import from another output

See also: Sage-Bionetworks-IT/organizations-infra#1306

@ConsoleCatzirl ConsoleCatzirl requested review from a team as code owners July 17, 2024 18:46
.github/workflows/deploy.yaml Outdated Show resolved Hide resolved
@ConsoleCatzirl ConsoleCatzirl requested a review from zaro0508 July 24, 2024 17:57
@ConsoleCatzirl ConsoleCatzirl marked this pull request as draft August 13, 2024 17:33
@ConsoleCatzirl ConsoleCatzirl marked this pull request as ready for review August 13, 2024 17:34
Upload test artifacts for branches that start with `test/` to the
'itsandbox' account. This automates a manual step needed for testing
changes to AMIs used by service catalog products.
update hook versions and configure automation to run monthly
Address E3009:, mode minimum length is 6 characters

Ignore E3012 for PyPlate

Address W3687: ['FromPort', 'ToPort'] are ignored when using 'IpProtocol' value '-1'

Ignore W6001: The output value is an import from another output
@ConsoleCatzirl ConsoleCatzirl changed the title [IT-3523] Upload 'testing' branch for pre-merge testing [IT-3523] Upload test artifacts for branches beginning with test/ Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants