IT-3317 #318
IT-3317 #318
Conversation
…it' and 'cfn-signal'
| --name reverse-proxy \ | ||
| --network ${NETWORK_NAME} \ | ||
| --restart unless-stopped \ | ||
| -e EC2_INSTANCE_ID=$(curl http://169.254.169.254/latest/meta-data/instance-id) \ |
There was a problem hiding this comment.
i think this needs to be updated to IMDSV2? related PR: Sage-Bionetworks/service-catalog-utils#25
There was a problem hiding this comment.
Apparently we do not have to update. I have tried this out in our dev Service Catalog and it works fine.
There was a problem hiding this comment.
it's because you are building on top of an older AWS AMI, the IMDSV1 will be removed in mid 2024. We should update to IMDSV2 either in this PR or in a follow on PR.
ConsoleCatzirl
force-pushed
the
master
branch
from
0f45e76 to
13a21de
Compare
| DependsOn: "InstanceProfile" | ||
| Type: Custom::SynapseTagger | ||
| Properties: | ||
| ServiceToken: !ImportValue |
There was a problem hiding this comment.
This lambda will take all of the ENV VARs defined in make_env_vars_file.sh file and apply them as EC2 instance tags. Some of those tags are very important to how the service catalog works. For example the value for the ACCESS_APPROVED_ROLEID tag is what is used to restrict instance access to the user who provisioned it. Since the make_env_vars_file.sh is no longer setup in this file i'm going to assume that those tags are no longer getting set. I think we'll need make_env_vars_file.sh or find an alternative way to set those tags.
There was a problem hiding this comment.
I see. Will add to the config.
|
🎉 All dependencies have been resolved ! |
Add template for dockerized service catalog notebook product.
This is modeled after the current RStudio notebook template, however instead of using the RStudio AMI it simply uses the base Ubuntu AMI and then runs the reverse proxy and notebook software as containers. This modularity allows the product to have the option of running either an RStudio or Jupyter notebook.
Depends on Sage-Bionetworks-IT/notebook-reverse-proxy#1