Skip to content

Commit

Permalink
IT-3317: fixed Docker image reference (must be lower case) (#320)
Browse files Browse the repository at this point in the history
* fixed Sub command

* fixed {NOTEBOOK_TYPE} ->

* fixed yaml

* idempotently create network; remote 'opt/aws/bin' prefix from 'cfn-init' and 'cfn-signal'

* pass instance-id from env to cfn-init command

* try defining EC2_INSTANCE_ID directly in command env

* IT-3317: add template for dockerized service catalog notebook product

* jupyter startup command works now

* updates from last CR; tested in SC-DEV

* upped the resources for the reverse proxy

* update reverse-proxy container version to match format required in proxy CI script

* Set env vars for tagging Lambda; use 'v2' of metadata services

* fixed Docker image reference (must be lower case)
  • Loading branch information
brucehoff authored Jan 12, 2024
1 parent 1b53b7f commit f034e26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion templates/ec2/sc-ec2-linux-docker-notebook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ Resources:
-e AWS_REGION=${AWS_REGION} \
-e SERVICE_CATALOG_PREFIX=${SERVICE_CATALOG_PREFIX} \
-e SSM_PARAMETER_SUFFIX=${SSM_PARAMETER_SUFFIX} \
ghcr.io/Sage-Bionetworks-IT/notebook-reverse-proxy-${NOTEBOOK_TYPE}:v1.0.0
ghcr.io/sage-bionetworks-it/notebook-reverse-proxy-${NOTEBOOK_TYPE}:v1.0.0
env:
AWS_REGION: !Ref AWS::Region
NETWORK_NAME:
Expand Down

0 comments on commit f034e26

Please sign in to comment.