Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agora): migrate Nominated Targets (AG-1551) #2864

Merged

Conversation

sagely1
Copy link
Contributor

@sagely1 sagely1 commented Sep 29, 2024

Description

  • Adding Nominated Targets Component
    ** Note: table on page will be implemented in a future PR
  • Removing teams dependency on legacy ApiService. Moving to OpenApi implementation.
  • Site-wide CSS updates (also using normalize.css to serve as a css reset)
  • Added shared components - SvgIcon and ModalLink

Testing

nx test agora-nominated-targets

Expected output

Navigate to:
http://localhost:4200/genes/nominated-targets

image

@sagely1 sagely1 changed the title Agora/migration nominated targets feat(agora): migrate Nominated Targets (AG-1551) Sep 30, 2024
@sagely1 sagely1 marked this pull request as ready for review October 1, 2024 19:50
@sagely1 sagely1 requested a review from a team as a code owner October 1, 2024 19:50
Copy link

sonarcloud bot commented Oct 1, 2024

Copy link

sonarcloud bot commented Oct 1, 2024

Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-image-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-challenge-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 1, 2024

Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-organization-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tschaffter tschaffter added this pull request to the merge queue Oct 2, 2024
Merged via the queue into Sage-Bionetworks:main with commit 7f424c7 Oct 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants