Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agora): migrate Footer component and utils (AG-1548) #2858

Merged
merged 6 commits into from
Sep 26, 2024
Merged

feat(agora): migrate Footer component and utils (AG-1548) #2858

merged 6 commits into from
Sep 26, 2024

Conversation

sagely1
Copy link
Contributor

@sagely1 sagely1 commented Sep 26, 2024 •
edited
Loading

Description

Migration of Footer component

Changelog

  • Footer has been added
  • added shared utils
  • updated home and footer component to use PathSanitizer util

Related Issue

https://sagebionetworks.jira.com/browse/AG-1548

Testing

nx test agora-home

Expected output

Navigate to:
http://localhost:4200

image

@sagely1 sagely1 changed the title Agora/migration footer feat(agora): migrate Footer component and utils Sep 26, 2024
@sagely1 sagely1 changed the title feat(agora): migrate Footer component and utils feat(agora): migrate Footer component and utils (AG-1548) Sep 26, 2024
@sagely1 sagely1 marked this pull request as ready for review September 26, 2024 17:42
@sagely1 sagely1 requested a review from a team as a code owner September 26, 2024 17:42
tschaffter
tschaffter requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments. In addition, the first comment of this PR has two sections "Changelog" that should be consolidated into one section that uses bullet points.

libs/agora/ui/src/lib/footer/footer.component.ts Outdated Show resolved Hide resolved
libs/agora/ui/src/lib/footer/footer.component.html Outdated Show resolved Hide resolved
libs/agora/ui/src/lib/footer/footer.component.html Outdated Show resolved Hide resolved
libs/agora/ui/src/lib/footer/footer.component.html Outdated Show resolved Hide resolved
libs/agora/ui/src/lib/footer/footer.component.html Outdated Show resolved Hide resolved
@tschaffter tschaffter self-requested a review September 26, 2024 20:27
@tschaffter tschaffter added this pull request to the merge queue Sep 26, 2024
Merged via the queue into Sage-Bionetworks:main with commit c824019 Sep 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagely1 @tschaffter