Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(openchallenges): add browsers for e2e testing with Playwright to the dev container #2391

Merged

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Dec 5, 2023

Closes #2387

Changelog

  • Add Chromium, FF and Webkit to the dev container for e2e testing with Playwright
  • Use the new recommended way to install Node.js

@tschaffter tschaffter self-assigned this Dec 5, 2023
@tschaffter
Copy link
Member Author

tschaffter commented Dec 5, 2023

Building the dev container shows this message. It's currently only slowing down the build by a few seconds.

 => [dev_container_auto_added_stage_label 2/8] RUN groupadd docker   && apt-get update -qq -y && export DEBIAN_FRONTEND=noninteractive   && apt-get install --no-install-recommends -qq  106.8s
 => => #                           SCRIPT DEPRECATION WARNING                                                                                                                                  
 => => # ================================================================================                                                                                                      
 => => # ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓                                                                                                      
 => => # ================================================================================                                                                                                      
 => => # TO AVOID THIS WAIT MIGRATE THE SCRIPT                                                                                                                                                 
 => => # Continuing in 60 seconds (press Ctrl-C to abort) ... 

This is because of node: https://stackoverflow.com/q/77021471

@tschaffter tschaffter marked this pull request as ready for review December 5, 2023 18:21
@tschaffter tschaffter merged commit be08406 into Sage-Bionetworks:main Dec 5, 2023
8 checks passed
@tschaffter tschaffter deleted the devcontainer-web-e2e-dependencies branch December 5, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story] Add system dependencies required to run e2e test for chromium, FF and webkit to the dev container
1 participant