feat(sage-monorepo): lint staged Dockerfiles with Hadolint (ARCH-278) (…

…#2829)

.hadolint.yaml

@@ -1,9 +1,9 @@
 ignored:
-  # Pin versions in apt-get install.
+  # Pin versions in `apt-get install`.
   # Reason: Identifying the versions of apt packages is not trivial. The versions available would
   # also differ for different base images. This decision should be re-evaluated periodically.
   - DL3008
-  # Pin versions in apt get install.
+  # Pin versions in `apk add`.
   # Reason: Identifying the versions of apk packages is not trivial. The versions available would
   # also differ for different base images. This decision should be re-evaluated periodically.
   - DL3018

lint-staged.config.js

@@ -19,4 +19,9 @@ module.exports = {
     // Lint the projects affected by the staged files
     `nx affected --target=lint --files=${filenames.join(',')}`,
   ],
+
+  '**/*[dD]ockerfile*': (filenames) => [
+    // Lint Dockerfiles with Hadolint
+    `hadolint ${filenames.join(' ')}`,
+  ],
 };

tools/devcontainers/sage/.devcontainer/Dockerfile

@@ -43,7 +43,6 @@ ENV DEVCONTAINER_VERSION=${devcontainerVersion} \
   LC_ALL=en_US.UTF-8
 
 # Install system packages
-# hadolint ignore=DL3008
 RUN apt-get update -qq -y && export DEBIAN_FRONTEND=noninteractive \
   && apt-get install --no-install-recommends -qq -y \
     ca-certificates curl git bash-completion gnupg2 lsb-release ssh sudo \