Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development environment cleanup #5625

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nickgros
Copy link
Contributor

  • Update wait-on to use full IP address, fixing integration in IntelliJ
  • Remove copy_eclipse_deps, no longer needed with yarn dev

Copy link
Contributor Author

@nickgros nickgros Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not using the Eclipse IDE integration, this file is no longer necessary (was it ever? I can't really remember why I had to create it--I never use Eclipse)

Comment on lines +67 to +68
"dev:watcher": "wait-on tcp:127.0.0.1:9876 && mvn fizzed-watcher:run",
"dev:tomcat": "wait-on tcp:127.0.0.1:9876 && docker pull tomcat:9.0; docker run --name swc-dev --rm -p 8888:8080 -v \"/$(pwd)/target/portal-develop-SNAPSHOT/:/usr/local/tomcat/webapps/ROOT/\" -v \"/$HOME/.m2/settings.xml\":/root/.m2/settings.xml tomcat:9.0",
Copy link
Contributor Author

@nickgros nickgros Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't work when running yarn dev via IntelliJ IDEA's NPM integration without the full IP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants