Moving changes from dev to stage #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hematic branch (#16) * Bumping resources closer to current deployment, point to latest rc schematic branch
andrewelamb
reviewed
Nov 15, 2024
| @@ -18,20 +18,23 @@ | |||
| "FQDN": "prod.schematic.io", | |||
| "CERTIFICATE_ARN": "arn:aws:acm:us-east-1:878654265857:certificate/d11fba3c-1957-48ba-9be0-8b1f460ee970", | |||
| "TAGS": {"CostCenter": "NO PROGRAM / 000000"}, | |||
| "SCHEMATIC_CONTAINER_LOCATION": "ghcr.io/sage-bionetworks/schematic:v0.1.94-beta", | |||
| } | |||
There was a problem hiding this comment.
Will this deploy to prod on this pr or does it wokr like the previous repo, where pushing to prod branch triggers deploy to prod.
There was a problem hiding this comment.
where pushing to prod branch triggers deploy to prod.
That is correct. Only changes deployed to the "prod" branch will be deployed to prod. My thought behind having this configured like this is that ahead of time we could update these values. We can also limit the number of changes that might need to be separate in each long-lived branches to keep them all in sync. Meaning we can always move changes up from dev -> stage -> prod without much thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating up changes to stage api.
Testing: