Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment in CI workflow #15

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

zaro0508
Copy link
Contributor

The github.ref_name reference is not reliable for getting the branch name. When pushing a stage branch that reference sets the environment to dev.

We change to explicitly pass in the correct enviornment for each workflow.

The github.ref_name reference is not reliable for getting the branch name.
When pushing a `stage` branch that reference sets the environment to `dev`.

We change to explicitly pass in the correct enviornment for each workflow.
@zaro0508 zaro0508 requested a review from a team as a code owner November 14, 2024 16:41
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zaro0508 zaro0508 merged commit 40060fe into Sage-Bionetworks-IT:dev Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants