Add IPv6 address support to linknets #296
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would be necessary to define a dual stack Linknet
This makes the new linknet ipv6 fields (corresponding to the existing ipv4 fields) to the device variable context.
If we don't the tests won't pass :)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263
At Sikt, we want to run the underlay directly on IPv6. This requires support for IPv6 network address fields on the Linknet model, which must also be supported by the API.
This is still in draft mode, currently awaiting two things:
infra_ipv6field to Devices, with the associated functionality. E.g., this is required to be able to populatebgp_ipv6_peersas a device variable, among other things.Whereas CNaaS-NMS requires an IPv4 linknet to be
/31, this PR will accept IPv6 linknets as large as/64, as this is standard practice in our case. Still, only the two first host addresses are picked from a linknet of this size.