Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D10 3 ian new #91

Open
wants to merge 80 commits into
base: 11.x
Choose a base branch
from
Open

D10 3 ian new #91

wants to merge 80 commits into from

Conversation

imonroe
Copy link
Contributor

@imonroe imonroe commented Nov 4, 2024

NOT READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to...
  4. Verify...

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

pookmish and others added 24 commits August 9, 2024 13:18
…#801)

* d8core-5741: fields first pass (#800)

* d8core-5741: role for opportunity content type

* d8core-5741: taxonomy, part 1

* d8core-5741: first of the geeneric taxonomy vocabs

* d8core-5741: permission fixes

* d8core-5741: the rest of the vocabs

* d8core-5741: first five fields

* d8core-5741: next 5 fields

* d8core-5741: next 2 fields

* d8core-5741: 5 more fields

* d8core-5741: first two taxonomy

* d8core-5741: last taxonomy as tags

* d8core-5741:unpublished, menu

* d8core-5741: rabbit hole, path

* d8core-5741: layout fix, form

* D8CORE-5741: removed extraneous taxonomy

* D8CORE-5741: adjusted settings so taxonomy is multilevel

* Adjust field configs

* updated field name

* Configured form settings and display settings and added some acceptance tests

---------

Co-authored-by: Mike Decker <[email protected]>
… (#799)

* D8CORE-7424 Added various HTML attributes to the WSYIWYG allowed list

* Fixups
* Updated contrib dependencies and configs

* reverted extlink update

* Updated tests for contrib updates

* Update test

* fix person test
* D8Core-7476: new field for site type

* D8Core-7476: putting stuff in the right spot
…#822)

* D8CORE-7564: removed decanter link and replaced with identity guide info.

* D8CORE-7564: added in a handy link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants