Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-6976: removed the italics on the caption #142

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • Removed the italics on the media caption

Review By (Date)

  • soon

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to a content page.
  4. Add a Text Paragraph
  5. Add an image and with caption inside the text area
  6. Verify the caption is not italic.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? NO

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-6976

Resources

@pookmish pookmish enabled auto-merge (squash) October 19, 2023 20:24
@pookmish pookmish merged commit 1763e7e into 10.x Oct 19, 2023
2 checks passed
@pookmish pookmish deleted the D8CORE-6976--italics branch October 19, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants