Adds gradients for breakpoints larger than xs #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherakama
requested review from
yvonnetangsu
and removed request for
ericbakenhus and
stfurkan
sherakama
reviewed
Jan 25, 2024
Comment on lines
+138
to
+140
| brick: 'xs:su-from-brick su-to-brick/30', | ||
| 'palo-alto-dark': 'xs:su-from-palo-alto-dark su-to-palo-alto-dark/30', | ||
| white: 'xs:su-from-white su-to-white/30', |
There was a problem hiding this comment.
You removed the xs from these here: 048f9a3#r1443322032 in #710
But they are not working as intended on the current site. This is to fix that. Can you look at this again please?
There was a problem hiding this comment.
Going to review this now - thanks for the ping @sherakama !
yvonnetangsu
approved these changes
Jan 25, 2024
Merged
|
It is live :) |
|
Thank you @yvonnetangsu and @sherakama ! |
|
Thank you for the fix @shc314 ! Sorry I messed it up 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Review Tasks
Setup tasks and/or behavior to test
At the xs breakpoint, the gradient starts at the top with the specified color at 30% opacity and then goes to #181D1C 100% opacity at the bottom.
For all widths larger than xs, the gradient starts at #181D1C 0% opacity at the top and then goes to the specified color 100% opacity at the bottom.
Associated Issues and/or People