Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center Associates Directory page intro text #739

Closed
wants to merge 3 commits into from

Conversation

moisesnarvaez
Copy link
Contributor

READY FOR REVIEW

Summary

image

Review By (Date)

  • When possible

Review Tasks

  1. Navigate to https://affiliates--stanford-alumni.netlify.app/stanford-associates/directory/
  2. Verify the text of the Intro component is centered

Associated Issues and/or People

Copy link
Contributor

@willyumfrancis willyumfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Update for text format to be the same as previous site.

@rebeccahongsf
Copy link
Contributor

The Associates site is hosted on Drupal so there are styling restrictions on the edible text field which is why the text was not aligned with the Associates widget record count, search field, and data.

Our suggestion would be to either:

  1. Leave it as-is on dev
  2. Center not only the text field but also the text itself as well (this can be done by adding su-text-center) to match other Alumni Homesite pages that have center text 😃
    image

image

Thoughts, @William-Misiaszek?

@willyumfrancis
Copy link
Contributor

This sounds like a great alternative @rebeccahongsf! Could you or @moisesnarvaez perform this update?

@sherakama
Copy link
Member

sherakama commented Nov 7, 2023

Who owns the work in this PR? Who is going to finish it?

@rebeccahongsf @moisesnarvaez @William-Misiaszek

@sherakama sherakama closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants