-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-42 DS-496 | Decanter and fonts update; small visual regression and bug fixes #710
Changes from all commits
803aacc
50a2d06
e74a185
dacbfe9
62bbab0
3f007af
575f852
18434df
aaae45e
073d7db
a8cb9fc
e6fc60f
048f9a3
0e8430d
0d6c727
34fb313
7cb4e88
94cd9b2
f4442fa
ee10a55
0a4fc47
0228f8b
959bfef
9c64443
b25521a
c5820b3
6f97cbf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
last 2 versions | ||
> 0.5%, | ||
last 2 versions, | ||
Firefox ESR, | ||
not dead |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,14 +14,11 @@ | |
"@fortawesome/pro-solid-svg-icons": "^5.15.4", | ||
"@fortawesome/react-fontawesome": "^0.2.0", | ||
"@heroicons/react": "^1.0.6", | ||
"@tailwindcss/aspect-ratio": "^0.4.2", | ||
"@tailwindcss/forms": "^0.5.7", | ||
"adapt-auth-sdk": "^1.0.20", | ||
"algoliasearch": "^4.20.0", | ||
"body-parser": "^1.20.2", | ||
"cnbuilder": "^3.1.0", | ||
"cookie-parser": "^1.4.6", | ||
"decanter": "^7.1.2", | ||
"fast-sort": "^3.4.0", | ||
"gatsby": "^4.25.7", | ||
"gatsby-link": "^4.25.0", | ||
|
@@ -65,7 +62,6 @@ | |
"storyblok-react": "^0.1.2", | ||
"storyblok-rich-text-react-renderer-ts": "^3.2.0", | ||
"tabbable": "^5.3.3", | ||
"tailwindcss-interaction-variants": "^5.0.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We no longer need this plugin since TW has expanded its variants offering |
||
"url-parse": "^1.5.10", | ||
"use-query-params": "^1.2.3", | ||
"xml2js": "^0.6.2" | ||
|
@@ -110,10 +106,12 @@ | |
"@babel/plugin-transform-runtime": "^7.23.4", | ||
"@babel/preset-env": "^7.23.5", | ||
"@babel/preset-react": "^7.23.3", | ||
"@tailwindcss/forms": "^0.5.7", | ||
"autoprefixer": "^10.4.16", | ||
"axios-mock-adapter": "^1.22.0", | ||
"cross-env": "^7.0.3", | ||
"cypress": "^13.6.0", | ||
"decanter": "^7.1.2", | ||
Comment on lines
+109
to
+114
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reinstall these as dev dependencies instead of dependencies |
||
"dotenv": "^16.3.1", | ||
"eslint": "^7.32.0", | ||
"eslint-config-airbnb": "^18.2.1", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,24 +2,24 @@ import { dcnb } from 'cnbuilder'; | |
|
||
export const root = ({ orientation, isDark }) => | ||
dcnb( | ||
'su-group su-relative su-w-full su-overflow-hidden su-bg-saa-black su-break-words su-basefont-23 su-bg-clip-padding su-border su-border-solid su-backface-hidden', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no longer a need to use su-border-solid in newer versions of TW. It's solid by default so only the su-border class is needed. |
||
'su-group su-relative su-w-full su-overflow-hidden su-bg-saa-black su-break-words su-basefont-23 su-bg-clip-padding su-border su-backface-hidden', | ||
{ | ||
'su-w-full md:su-flex-row xl:su-h-500': orientation === 'horizontal', | ||
'sm:su-max-w-[42rem] md:su-max-w-full': orientation !== 'horizontal', | ||
'su-border-black hover:su-border-black-90 focus-within:su-border-black-90': | ||
isDark || orientation === 'horizontal', | ||
'su-border-black-30-opacity-40 hover:su-border-black-30 focus-within:su-border-black-30': | ||
'su-border-black-30/40 hover:su-border-black-30 focus-within:su-border-black-30': | ||
!isDark && orientation !== 'horizontal', | ||
} | ||
); | ||
export const imageWrapper = ({ orientation }) => | ||
dcnb('su-relative su-overflow-hidden', { | ||
'su-w-full su-mb-[-4em] md:su-mb-0 md:su-w-1/2 su-h-[60vw] sm:su-h-[50vw] lg:su-h-[40vw] xl:su-h-500 su-flex-shrink-0 su-h-full': | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'su-w-full su-mb-[-4em] md:su-mb-0 md:su-w-1/2 su-h-[60vw] sm:su-h-[50vw] lg:su-h-[40vw] xl:su-h-500 su-shrink-0 su-h-full': | ||
orientation === 'horizontal', | ||
'su-aspect-w-3 su-aspect-h-2 su-mb-[-3em]': orientation !== 'horizontal', | ||
}); | ||
export const image = | ||
'su-w-full su-h-full su-transition-transform su-transform-gpu group-hover:su-scale-[1.03] group-focus-within:su-scale-[1.03]'; | ||
'su-w-full su-h-full su-transition-transform su-transform-gpu group-hocus-within:su-scale-[1.03]'; | ||
export const gradient = ({ orientation }) => | ||
dcnb( | ||
'su-absolute su-block su-w-full su-h-[101%] su-top-0 su-left-0 su-from-transparent su-to-saa-black su-backface-hidden su-bg-gradient-to-b', | ||
|
@@ -31,7 +31,7 @@ export const contentWrapper = ({ orientation }) => | |
dcnb('su-rs-px-2 su-rs-pb-3', { | ||
'su-w-full md:su-w-9/12 lg:su-w-7/12 lg:su-max-w-[72rem] md:su-self-end md:su-rs-pt-3 md:su-pl-0 md:su-ml-[-7em]': | ||
orientation === 'horizontal', | ||
'su-flex-grow': orientation !== 'horizontal', | ||
'su-grow': orientation !== 'horizontal', | ||
}); | ||
export const link = ({ orientation }) => | ||
dcnb( | ||
|
@@ -43,8 +43,8 @@ export const link = ({ orientation }) => | |
); | ||
export const heading = 'su-relative su-inline su-type-0'; | ||
export const icon = | ||
'su-relative su-inline-block su-text-digital-red-xlight group-hover:su-text-white group-focus:su-text-white'; | ||
'su-relative su-inline-block su-text-digital-red-xlight group-hocus:su-text-white'; | ||
export const description = ({ orientation }) => | ||
dcnb('su-relative su-text-black-20 su-flex-grow su-mb-0 su-card-paragraph', { | ||
dcnb('su-relative su-text-black-20 su-grow su-mb-0 su-card-paragraph', { | ||
'xl:su-big-paragraph xl:su-leading-snug': orientation === 'horizontal', | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been removed because it's in decanter core