-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-42 DS-496 | Decanter and fonts update; small visual regression and bug fixes #710
Merged
Merged
Changes from 10 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
803aacc
use node v18; update browserslistrc to match MyAccount etc; reinstall…
yvonnetangsu 50a2d06
Replace su-flex-grow with su-grow, su-flex-shrink-0 with su-shrink-0
yvonnetangsu e74a185
Update google font import; unintall tailwindcss-interaction-variants;…
yvonnetangsu dacbfe9
Fix one T/S visual bug that's been bothering me
yvonnetangsu 62bbab0
Global Footer update; T/S mobile menu background color fixup; remove …
yvonnetangsu 3f007af
Replace group-hover group-focus with group-hocus (plus other of our c…
yvonnetangsu 575f852
User menu link bump up to 19px (a11y)
yvonnetangsu 18434df
continue
yvonnetangsu aaae45e
Merge branch 'dev' into feature/DS-42_update-decanter-fonts
yvonnetangsu 073d7db
linter
yvonnetangsu a8cb9fc
Merge branch 'dev' into feature/DS-42_update-decanter-fonts
yvonnetangsu e6fc60f
Remove TW plugins
yvonnetangsu 048f9a3
Fix hero gradients
yvonnetangsu 0e8430d
Use TW default notation for opacity and remove old custom color theme…
yvonnetangsu 0d6c727
Remove all border-solid and border-1 classes
yvonnetangsu 34fb313
Remove gsbCard component which probably sneaked in when dealing with …
yvonnetangsu 7cb4e88
Getting rid of square brackets when not needed; use rem instead of px
yvonnetangsu 94cd9b2
Fix masthead and global header (TS version of masthead) mobile icon p…
yvonnetangsu f4442fa
avatars fixup
yvonnetangsu ee10a55
decanter and Tw plugin can be dev dependencies
yvonnetangsu 0a4fc47
Fix mega menu 2nd level menu padding
yvonnetangsu 0228f8b
Modal close button fixups
yvonnetangsu 959bfef
Fix vertical position of CTA link heroicon when placed on the left; r…
yvonnetangsu 9c64443
T/S mobile section menu background color fix
yvonnetangsu b25521a
TS trip filter modal fix for mobile
yvonnetangsu c5820b3
chips wrapper padding
yvonnetangsu 6f97cbf
Update .browserslistrc
sherakama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
last 2 versions | ||
> 0.5%, | ||
last 2 versions, | ||
Firefox ESR, | ||
not dead |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
16 | ||
18 |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,12 +14,12 @@ export const root = ({ orientation, isDark }) => | |
); | ||
export const imageWrapper = ({ orientation }) => | ||
dcnb('su-relative su-overflow-hidden', { | ||
'su-w-full su-mb-[-4em] md:su-mb-0 md:su-w-1/2 su-h-[60vw] sm:su-h-[50vw] lg:su-h-[40vw] xl:su-h-500 su-flex-shrink-0 su-h-full': | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'su-w-full su-mb-[-4em] md:su-mb-0 md:su-w-1/2 su-h-[60vw] sm:su-h-[50vw] lg:su-h-[40vw] xl:su-h-500 su-shrink-0 su-h-full': | ||
orientation === 'horizontal', | ||
'su-aspect-w-3 su-aspect-h-2 su-mb-[-3em]': orientation !== 'horizontal', | ||
}); | ||
export const image = | ||
'su-w-full su-h-full su-transition-transform su-transform-gpu group-hover:su-scale-[1.03] group-focus-within:su-scale-[1.03]'; | ||
'su-w-full su-h-full su-transition-transform su-transform-gpu group-hocus-within:su-scale-[1.03]'; | ||
export const gradient = ({ orientation }) => | ||
dcnb( | ||
'su-absolute su-block su-w-full su-h-[101%] su-top-0 su-left-0 su-from-transparent su-to-saa-black su-backface-hidden su-bg-gradient-to-b', | ||
|
@@ -31,7 +31,7 @@ export const contentWrapper = ({ orientation }) => | |
dcnb('su-rs-px-2 su-rs-pb-3', { | ||
'su-w-full md:su-w-9/12 lg:su-w-7/12 lg:su-max-w-[72rem] md:su-self-end md:su-rs-pt-3 md:su-pl-0 md:su-ml-[-7em]': | ||
orientation === 'horizontal', | ||
'su-flex-grow': orientation !== 'horizontal', | ||
'su-grow': orientation !== 'horizontal', | ||
}); | ||
export const link = ({ orientation }) => | ||
dcnb( | ||
|
@@ -43,8 +43,8 @@ export const link = ({ orientation }) => | |
); | ||
export const heading = 'su-relative su-inline su-type-0'; | ||
export const icon = | ||
'su-relative su-inline-block su-text-digital-red-xlight group-hover:su-text-white group-focus:su-text-white'; | ||
'su-relative su-inline-block su-text-digital-red-xlight group-hocus:su-text-white'; | ||
export const description = ({ orientation }) => | ||
dcnb('su-relative su-text-black-20 su-flex-grow su-mb-0 su-card-paragraph', { | ||
dcnb('su-relative su-text-black-20 su-grow su-mb-0 su-card-paragraph', { | ||
'xl:su-big-paragraph xl:su-leading-snug': orientation === 'horizontal', | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need this plugin since TW has expanded its variants offering