Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev ffw #3

Merged
merged 21 commits into from
Aug 16, 2023
Merged

Dev ffw #3

merged 21 commits into from
Aug 16, 2023

Conversation

botanic
Copy link
Collaborator

@botanic botanic commented Aug 14, 2023

Summary

This PR is providing redesign of the following components and paragraphs:

  1. Lists component (Redesign of Card grid layout for News, two color variants - Dark grey, Light grey)
  2. Footer background color update
  3. Various fixes from the SWS feedback

Lists component

Design: https://www.figma.com/file/rdWOMTXAKhtTazxTdczoYx/Stanford-Transportation?type=design&node-id=55-2096&mode=design&t=RaX1F4gbWObbkHyn-0
(Note that upper cards in figma are showing 4 items in a row. This is not aligned to the functionality in Drupal. List component will show 3 cards in a row in grid layout, and width of the whole component is smaller than other ones)

New card colors are introduced:

  • Dark grey
  • Light grey

In agreement with the client, following adjustments were also applied to the Cards component (News):

  • Date is added programmatically, since date field was not visible in the view mode
  • Label (next to the date) is removed
  • Tags (originally present in cards) were removed

Footer color update

Footer background color is updated to match the footer on https://alumni.stanford.edu/

Various fixes from the SWS feedback

Refer to this PR for requested updates.

Adrian L and others added 21 commits July 18, 2023 17:12
Feature/STDD-10

Approved-by: Vladimir Zdravkovic
STDD-10: Fix external icon webkit mask.

Approved-by: Vladimir Zdravkovic
STDD-2: Update centering js code.

Approved-by: Adrian Lukanov
Approved-by: Vladimir Zdravkovic
STDD-10: Fix QA issues.

Approved-by: Vladimir Zdravkovic
…to custom to be like alumni theme one. Change the external icons for utility nav to have more contrast for accessibility. Remove color variables, that have the same decanter default color.
STDD-14: Update theme info, readme, screenshot, fixes.

Approved-by: Vladimir Zdravkovic
STDD-14: Update readme.

Approved-by: Vladimir Zdravkovic
STDD-14: Update maintenance contact.

Approved-by: Vladimir Zdravkovic
Copy link
Contributor

@buttonwillowsix buttonwillowsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to Yvonne and Jen. We are pushing and tagging.

@buttonwillowsix buttonwillowsix merged commit a804978 into 1.x Aug 16, 2023
1 check passed
@buttonwillowsix buttonwillowsix deleted the dev-ffw branch August 16, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants