-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev ffw #3
Merged
Merged
Dev ffw #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-subtheme into feature/STDD-10
Feature/STDD-10 Approved-by: Vladimir Zdravkovic
…tion-subtheme into feature/STDD-10
STDD-10: Fix external icon webkit mask. Approved-by: Vladimir Zdravkovic
STDD-2: Update centering js code. Approved-by: Adrian Lukanov Approved-by: Vladimir Zdravkovic
STDD-10: Fix QA issues. Approved-by: Vladimir Zdravkovic
…to custom to be like alumni theme one. Change the external icons for utility nav to have more contrast for accessibility. Remove color variables, that have the same decanter default color.
STDD-14: Update theme info, readme, screenshot, fixes. Approved-by: Vladimir Zdravkovic
STDD-14: Update readme. Approved-by: Vladimir Zdravkovic
STDD-14: Update maintenance contact. Approved-by: Vladimir Zdravkovic
buttonwillowsix
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to Yvonne and Jen. We are pushing and tagging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is providing redesign of the following components and paragraphs:
Lists component
Design: https://www.figma.com/file/rdWOMTXAKhtTazxTdczoYx/Stanford-Transportation?type=design&node-id=55-2096&mode=design&t=RaX1F4gbWObbkHyn-0
(Note that upper cards in figma are showing 4 items in a row. This is not aligned to the functionality in Drupal. List component will show 3 cards in a row in grid layout, and width of the whole component is smaller than other ones)
New card colors are introduced:
In agreement with the client, following adjustments were also applied to the Cards component (News):
Footer color update
Footer background color is updated to match the footer on https://alumni.stanford.edu/
Various fixes from the SWS feedback
Refer to this PR for requested updates.