Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSS-24: corrected the unpublished banner #16

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Oct 21, 2024

READY FOR REVIEW

Summary

  • Changed the text color for the su-alert--warning from black to white for a11y.

Review By (Date)

  • soon

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to an unpublished page.
  3. Verify it has white text.
  4. Verify other global warnings have no change.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- TSS-24

Resources

Copy link

@rebeccahongsf rebeccahongsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

@rebeccahongsf rebeccahongsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still solid! Thank you Jen 😎

@jenbreese jenbreese merged commit 0989a2d into 1.x Oct 28, 2024
1 check passed
@jenbreese
Copy link
Contributor Author

@buttonwillowsix Can you tag and release this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants