FMS-7: a11y focus

[jenbreese]

READY FOR REVIEW

Summary

• Trapping the tabs until disclaimer is accepted

Review By (Date)

• time allows

Criticality

• normal

Urgency

• normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Rebuild Cache and import config drush cr ; drush ci
3. Navigate to...
4. Verify...

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- FMS-7

Resources

• Automated Accessibility Testing: Siteimprove
• Manual Accessibility Testing Script SWS Accessibility Process and Checklist
• HTML Validation for one URL: HTML Validator
• HTML Validation for multiple URLs: Bulk W3C Validator
• Crossbrowser Testing: Browserstack and link to Browserstack Credentials
• Visual Regression Testing: Diffy and link to Diffy Credentials

[jenbreese]

@buttonwillowsix This change was approved by ODA. Can you review and merge?

[rebeccahongsf]

LGTM 🚀 Thanks Jen!