add command to do package release branches #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imonroe
approved these changes
Sep 8, 2021
| */ | ||
| public function swsReleases($options = ['packages' => '']) { | ||
| $docroot = $this->getConfigValue('docroot'); | ||
| foreach (glob("$docroot/*/custom/*/*info.yml") as $package) { |
There was a problem hiding this comment.
This is neat. I was using arrays of our packages.
| ->run() | ||
| ->getMessage(); | ||
|
|
||
| $matches = preg_grep('/^-.*su-.*?$/', explode("\n", $composer_diff)); |
There was a problem hiding this comment.
I like this; nice and efficient and it lets composer do the work.
| ->push('origin', "release-$release_version") | ||
| ->run(); | ||
| sleep(1); | ||
| $this->taskExec("gh pr create -B $base_branch --title $release_version --body $version") |
There was a problem hiding this comment.
Worth noting that it requires gh be installed, which is likely not the case for everyone. 🤷
| ->setHeader(implode(PHP_EOL, $header)) | ||
| ->setBody(implode("\n", $log) . PHP_EOL) | ||
| ->anchor($anchor) | ||
| ->run(); |
There was a problem hiding this comment.
This would be the right place to extract the changes for staci, et. al. if you just append them to a file somewhere convenient, yeah?
| ->run(); | ||
| } | ||
|
|
||
| $finder = new Finder(); |
imonroe
approved these changes
Sep 13, 2021
pookmish
force-pushed
the
release-packages
branch
from
789c0de
to
8e0f5ae
Compare
pookmish
force-pushed
the
release-packages
branch
from
8e0f5ae
to
03fa698
Compare
pookmish
force-pushed
the
release-packages
branch
from
03fa698
to
98d2210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW/NOT READY
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)See Also