Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drupal:toggle:modules command from post install hook #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imonroe
Copy link

@imonroe imonroe commented May 13, 2022

READY FOR REVIEW

Summary

Needed By (Date)

  • 🤷

Urgency

  • low

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@pookmish
Copy link
Contributor

I'd like to keep the backwards compatibility for now. H&S relies on that command heavily.

@imonroe
Copy link
Author

imonroe commented May 13, 2022

Well, I'll just leave this here then, and we can merge it if/when it no longer matters to H&S.

@pookmish
Copy link
Contributor

I'm just going to remove myself as reviewer so it keeps my "assigned" list clean. we'll merge this PR maybe when we get all our stacks up to PHP8

@pookmish pookmish removed their request for review May 13, 2022 16:25
@pookmish pookmish removed their assignment May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants